feat: client evaluation context getter and setter#610
Closed
karnyadavdev wants to merge 4 commits into
Closed
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds getter and setter properties for evaluation_context to the Client class, along with a corresponding unit test. The reviewer suggests updating the setter to default to an empty EvaluationContext if None is passed, which prevents potential type annotation violations and ensures consistency with the class's initialization logic.
karnyadavdev
force-pushed
the
feat-client-evaluation-context-setter
branch
from
9ac6ddb to
0a96426
Compare
Signed-off-by: Karan Yadav <47368518+karnyadavdev@users.noreply.github.com>
Signed-off-by: Karan Yadav <47368518+karnyadavdev@users.noreply.github.com>
Author
|
review this pr |
Member
|
Duplicate of #593 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #500
Exposes
evaluation_contextas a property getter and setter onOpenFeatureClientto support getting and setting a client-wide evaluation context, matching requirements from the OpenFeature specification.Added a dedicated unit test in
tests/test_client.pyto verify getting and setting.